Skip to content

[test do not merge] snapshot golden tests#1446

Draft
ludfjig wants to merge 23 commits into
hyperlight-dev:mainfrom
ludfjig:snapshot-golden-tests
Draft

[test do not merge] snapshot golden tests#1446
ludfjig wants to merge 23 commits into
hyperlight-dev:mainfrom
ludfjig:snapshot-golden-tests

Conversation

@ludfjig
Copy link
Copy Markdown
Contributor

@ludfjig ludfjig commented May 8, 2026

No description provided.

ludfjig added 15 commits May 6, 2026 14:11
@ludfjig
Refactor SandboxMemoryLayout
f763d61 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Move sandbox snapshot.rs into snapshot module dir
d58ed12 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Remove unused get_file_mappings_pointer_offset
b60bb6f 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Expose SandboxMemoryLayout fields to crate
6f9cab9 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Extract HyperlightVm apply_sregs helper
8d4ffd7 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Introduce HostFunctions newtype for sandbox construction
dc0d08b 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Add file backed ReadonlySharedMemory
8152f0f 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Persist host function metadata in Snapshot
ea7fb93 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Make gdb work for already initialised snapshots
5d80eac 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Add MultiUseSandbox from_snapshot
9d00b24 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Add snapshot file format with persistence and load
e37900b 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Add tests for snapshot file format
9e0334c 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Add snapshot file benchmarks
7fd38b1 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
Add gdb test for MultiUseSandbox from_snapshot
621cc03 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
WIP: snapshot ABI tripwires + golden tests
033c551 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig added the regen-goldens Regenerate snapshot golden fixtures label May 8, 2026
@ludfjig
WIP: cross-load helpers + workflow upload glob + bypass env var
3a6f6f4 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig added regen-goldens Regenerate snapshot golden fixtures and removed regen-goldens Regenerate snapshot golden fixtures labels May 11, 2026
ludfjig added 2 commits May 11, 2026 13:41
@ludfjig
WIP: fix fetch-snapshot-goldens on Windows (Test-Path guard)
26bb3ab 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
WIP: normalize segment hidden-cache fields on snapshot write
f1ce942 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig added regen-goldens Regenerate snapshot golden fixtures and removed regen-goldens Regenerate snapshot golden fixtures labels May 11, 2026
@ludfjig
WIP: snapshot goldens: split fixtures by hv/cpu/profile + cross-load CI
e7bd956 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig added regen-goldens Regenerate snapshot golden fixtures and removed regen-goldens Regenerate snapshot golden fixtures labels May 11, 2026
ludfjig added 2 commits May 11, 2026 15:19
@ludfjig
WIP: add 24 snapshot golden fixtures (3 hv * 2 cpu * 2 profile * 2 ki…
a184c22 
…nds)

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
WIP: build-test fail-fast=false; cross-load goldens covers self-cell too
ca8c992 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig
WIP: normalize tr.type busy bit; cross-load skip self-cell
491a35d 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig added regen-goldens Regenerate snapshot golden fixtures and removed regen-goldens Regenerate snapshot golden fixtures labels May 11, 2026
@ludfjig
WIP: regen call goldens with normalized tr.type
d40106d 
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbugs danbugs Awaiting requested review from danbugs danbugs will be requested when the pull request is marked ready for review danbugs is a code owner

@devigned devigned Awaiting requested review from devigned devigned will be requested when the pull request is marked ready for review devigned is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz will be requested when the pull request is marked ready for review dblnz is a code owner

@jsturtevant jsturtevant Awaiting requested review from jsturtevant jsturtevant will be requested when the pull request is marked ready for review jsturtevant is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes will be requested when the pull request is marked ready for review jprendes is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically will be requested when the pull request is marked ready for review syntactically is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies will be requested when the pull request is marked ready for review simongdavies is a code owner

@andreiltd andreiltd Awaiting requested review from andreiltd andreiltd will be requested when the pull request is marked ready for review andreiltd is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

regen-goldens Regenerate snapshot golden fixtures

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ludfjig